-
-
Notifications
You must be signed in to change notification settings - Fork 403
API Clean-up (2) & Fixes #1868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
API Clean-up (2) & Fixes #1868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct#1586) - Fixed Background effect is started when instance is disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Disable streaming cmds for HTTP/S
Align setEffect instance definition with standard
Clean-up subscriptions, ensure downward compatibility
Fixed Toggle-Buttons on Dashboard
Fixed Crash when XCB,X11,Qt grabber were configured and display manager changed to Wayland
Fixed Target-directory not correctly build when exporting effects
Fixed Effect not suspended when instance is stopped (Effect not suspended when instance is stopped #1586)
Fixed Background effect is started when instance is disabled
Fixed - GlobalSignals were not really global resulting input loss when toggling an instance off/on
Fixed Stopped instance objects were not destructed, as reference still exist
Added support for tracking creation/deletion of SmartPointer objects
Fixed Exit handling in main module
Updated Supported platforms
What kind of change does this PR introduce? (check at least one)
If changing the UI of web configuration, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing setups:
The PR fulfills these requirements:
Fixes: #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:
fixes #1586